Error bars #113
Error bars #113
Conversation
- Working with error bars on Timeline view
- Updating jqPlot to 1.0.0b2 - Adding new js file (jqplot.ohlcRendererWithErrorBars.min.js), which is a modified OHLCRenderer to allow rendering error bars - Adding new option to settings.py (use_error_bars) to choose to use error bars or not
- Adding a checkbox to toggle error bars on or off
- Updating jqPlot to 1.0.0b2 - Adding new js file (jqplot.ohlcRendererWithErrorBars.min.js), which is a modified OHLCRenderer to allow rendering error bars - Adding new option to settings.py (use_error_bars) to choose to use error bars or not
|
Awesome. Will test it thoroughly with different data sets |
|
The error bars look great. Some point to notice:
|
|
Also, is there a reason why you are using jqplot.ohlcRendererWithErrorBars.js instead of the minified version? |
|
The zoom doesn't seem to work either... |
|
Other than those details, the error bars seem very usable, so that they could be turned on by default. Good work. |
|
Thanks :) I'll fix these problems and pull request again. About the minified version, I just forgot to do it. |
|
The last two commits added the class "options" to the error bars options span, changed the jqplot.ohlcRendererWithErrorBars to the minified version and the option to show the error bars is on by default. The zoom is working fine here. I guess the padding problem is because the number of series in the plot. I'll remove the error bars series from this calcultion. Can you provide me the data with PyPy's sphinx benchmark? Thanks |
|
I just removed the padding when using error bars |
|
the too big padding happens when the legend is inside the plot. See this screenshot |
|
Another issue is that this branch added the file |
- BUGFIX: error bars were not being ploted
- BUGFIX: fixing padding inside charts in timeline view
|
This PR is quite old now, and conflicts with the comprehensive upgrade PR I just opened (#199). But the actual changes look similar to something I am trying to implement (support for benchmarks with median+quartile data instead of mean+std_dev), and I might be able to leverage any overlap. If no one has objections, I'll have a go at cherry-picking the implementation out of this PR. |
|
I have recreated this PR on top of #199 in this branch. I'll make a PR for it if/when #199 is merged (because GitHub doesn't allow changing the branch that a PR should be merged into). |
|
@str4d that sounds great! I'll close this one. |
This pull request contains the changes to use error bars using standard deviation on timeline plots